[
https://issues.apache.org/jira/browse/YARN-7461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247143#comment-16247143
]
Tao Yang commented on YARN-7461:
--------------------------------
Thanks [~templedf] for your comments. I wrongly assumed that lhs is fit in rhs
and ignored the case you mentioned. I think the right calculations with zero
for DominantResourceCalculator#ratio should be:
<1,1,0> / <1,1,1> = 1;
<1,1,1> / <1,1,0> = INFINITY;
<1,1,0> / <1,1,0> = 1;
Thoughts?
> DominantResourceCalculator#ratio calculation problem when right resource
> contains zero value
> --------------------------------------------------------------------------------------------
>
> Key: YARN-7461
> URL: https://issues.apache.org/jira/browse/YARN-7461
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0-alpha4
> Reporter: Tao Yang
> Assignee: Tao Yang
> Priority: Minor
> Attachments: YARN-7461.001.patch, YARN-7461.002.patch
>
>
> Currently DominantResourceCalculator#ratio may return wrong result when right
> resource contains zero value. For example, there are three resource types
> such as <memory-mb, vcores, vssd>, leftResource=<5, 5, 0> and
> rightResource=<10, 10, 0>, we expect the result of
> DominantResourceCalculator#ratio(leftResource, rightResource) is 0.5 but
> currently is NaN.
> There should be a verification before divide calculation to ensure that
> dividend is not zero.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
