[
https://issues.apache.org/jira/browse/YARN-7495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253703#comment-16253703
]
Jason Lowe commented on YARN-7495:
----------------------------------
Thanks for the patch!
Looks good overall. The readability would be significantly improved with a
utility method to delete a path and log any IOException. There would be a lot
less nested try blocks as a result.
The tab characters should be cleaned up.
> Improve robustness of the AggregatedLogDeletionService
> ------------------------------------------------------
>
> Key: YARN-7495
> URL: https://issues.apache.org/jira/browse/YARN-7495
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: log-aggregation
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Attachments: YARN-7495.001.patch
>
>
> The deletion tasks are scheduled with a TimerTask whose scheduler is a Timer
> scheduleAtFixedRate. If an exception occurs in the log deletion task, the
> Timer scheduler interprets this as a task cancelation and stops scheduling
> future deletion tasks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
