[
https://issues.apache.org/jira/browse/YARN-7485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mehran Hassani updated YARN-7485:
---------------------------------
Description:
I am conducting research on log related bugs. I tried to make a tool to fix
repetitive yet simple patterns of bugs that are related to logs. In these
files, there are debug level logging statements containing multiple string
concatenation without the if statement before them:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/HadoopYarnProtoRPC.java,
LOG.debug("Creating a HadoopYarnProtoRpc server for protocol " + protocol +"
with " + numHandlers + " handlers");, 61
Would you be interested in adding the if before these logging statements?
There are 15 more cases that I can mention if needed.
was:
I am conducting research on log related bugs. I tried to make a tool to fix
repetitive yet simple patterns of bugs that are related to logs. In these
files, there are debug level logging statements containing multiple string
concatenation without the if statement before them:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/HadoopYarnProtoRPC.java,
LOG.debug("Creating a HadoopYarnProtoRpc server for protocol " + protocol +"
with " + numHandlers + " handlers");, 61
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java,
LOG.debug("Received node update event:" + type + " for node:" + node+ " with
state:" + nodeState);, 985
Would you be interested in adding the if before these logging statements?
There are 14 more cases that I can mention if needed.
> Add LOG.isDebugEnabled() guard for LOG.debug("")
> ------------------------------------------------
>
> Key: YARN-7485
> URL: https://issues.apache.org/jira/browse/YARN-7485
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Mehran Hassani
> Priority: Minor
>
> I am conducting research on log related bugs. I tried to make a tool to fix
> repetitive yet simple patterns of bugs that are related to logs. In these
> files, there are debug level logging statements containing multiple string
> concatenation without the if statement before them:
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/HadoopYarnProtoRPC.java,
> LOG.debug("Creating a HadoopYarnProtoRpc server for protocol " + protocol +"
> with " + numHandlers + " handlers");, 61
> Would you be interested in adding the if before these logging statements?
> There are 15 more cases that I can mention if needed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
