[
https://issues.apache.org/jira/browse/YARN-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253818#comment-16253818
]
Sunil G commented on YARN-7438:
-------------------------------
Thanks [~leftnoteasy] for the effort here.
Some general comments:
# lastPendingAsk and newPendingAsk seems a little tricky to understand and its
per Scheduler Key. Could we rename this better.
# A general doubt regarding {{ContainerRequest}}. Once we save set of resource
requests associated with a given container, it might have various resource
names (node local, rack local etc). But ANY will be common (accumulated count)
for all container demand on given Scheduler Key. This is a refactoring ticket,
so I just noticed this while a common class was created for same. Pls correct
me if I am wrong.
# lastPendingAsk could be cached?
> Additional changes to make SchedulingPlacementSet agnostic to ResourceRequest
> / placement algorithm
> ---------------------------------------------------------------------------------------------------
>
> Key: YARN-7438
> URL: https://issues.apache.org/jira/browse/YARN-7438
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-7438.001.patch
>
>
> In additional to YARN-6040, we need to make changes to SchedulingPlacementSet
> to make it:
> 1) Agnostic to ResourceRequest (so once we have YARN-6592 merged, we can add
> new SchedulingPlacementSet implementation in parallel with
> LocalitySchedulingPlacementSet to use/manage new requests API)
> 2) Agnostic to placement algorithm (now it is bind to delayed scheduling, we
> should update APIs to make sure new placement algorithms such as complex
> placement algorithms can be implemented by using SchedulingPlacementSet).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
