[
https://issues.apache.org/jira/browse/YARN-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255698#comment-16255698
]
Arun Suresh commented on YARN-7448:
-----------------------------------
[~pg1...@imperial.ac.uk], next time let me know before I submit a patch that
you'd like to work on it - Ill assign it to you then :)
bq. We need to expose an AllocateRequest new instance with schedulingRequest
List as parameter
That was intentional - In general, we would like to start using builders more,
rather than add more newInstance methods.
bq. ResourceSizing is never set in the SchedulingRequest constructor
You mean the SchedulingRequestBuilder constructor - True, but neither are a
bunch of other things like PlacementConstraints, Allocation tags etc. But,
given that it is probably a required field - might not be a bad idea to add it.
bq. We might need to implement equals and hashcode for the complex
ResourceSizing object
No harm in adding - but when testing the Equality of SchedulingRequest objects,
the internal PBImpl object already implements an equals and hashcode which
takes care of its inner fields.
Will assign this to you - can you put in another patch with the extra
newInstance method ?
> [API] Add SchedulingRequest to the AllocateRequest
> --------------------------------------------------
>
> Key: YARN-7448
> URL: https://issues.apache.org/jira/browse/YARN-7448
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-7448-YARN-6592.001.patch,
> YARN-7448-YARN-6592.002.patch, YARN-7448-YARN-6592.003.patch
>
>
> YARN-6594 introduces the {{SchedulingRequest}}. This JIRA tracks the
> inclusion of the SchedulingRequest into the AllocateRequest.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
