[ 
https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256488#comment-16256488
 ] 

Manikandan R edited comment on YARN-7119 at 11/17/17 5:24 AM:
--------------------------------------------------------------

[~templedf] Thanks for detailed reviews.

1: Currently if there is any non-alpha characters in units, still we extract 
the value part safely with units as "". Please help me to understand.
2-11: Addressed all these points. Added couple of more test cases to cover #8.
12: Point no. #11 will ensure arg\[2\] contains only numeric. But this check is 
required to ensure that key value (with "=" as delimiter) pairs has been 
passed. For example, memory-mb=1024Mi,*vcores1*,resource=2G should be treated 
as invalid argument. Please refer 
TestRMAdminCLI#testUpdateNodeResourceTypesWithInvalidResourceFormat() test case.


was (Author: maniraj...@gmail.com):
[~templedf] Thanks for detailed reviews.

1: Currently if there is any non-alpha characters in units, still we extract 
the value part safely with units as "". Please help me to understand.
2-11: Addressed all these points. Added couple of more test cases to cover #8.
12: Point no. #11 will ensure arg\[2\] contains only numeric. But this check is 
required to ensure that key value (with "=" as delimiter) pairs has been 
passed. For example, memory-mb=1024Mi,*vcores1*,resource=2G should be treated 
as invalid argument.

> yarn rmadmin -updateNodeResource should be updated for resource types
> ---------------------------------------------------------------------
>
>                 Key: YARN-7119
>                 URL: https://issues.apache.org/jira/browse/YARN-7119
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>    Affects Versions: YARN-3926
>            Reporter: Daniel Templeton
>            Assignee: Manikandan R
>         Attachments: YARN-7119.001.patch, YARN-7119.002.patch, 
> YARN-7119.002.patch, YARN-7119.003.patch, YARN-7119.004.patch, 
> YARN-7119.004.patch, YARN-7119.005.patch, YARN-7119.006.patch, 
> YARN-7119.007.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to