[ 
https://issues.apache.org/jira/browse/YARN-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741509#comment-13741509
 ] 

Bikas Saha commented on YARN-881:
---------------------------------

Fairly straight-foward change. Looks good to me. Jian, did you get a chance to 
run all tests with the patch to make sure we arent regressing?
                
> Priority#compareTo method seems to be wrong.
> --------------------------------------------
>
>                 Key: YARN-881
>                 URL: https://issues.apache.org/jira/browse/YARN-881
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-881.patch
>
>
> if lower int value means higher priority, shouldn't we "return 
> other.getPriority() - this.getPriority() " 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to