[ 
https://issues.apache.org/jira/browse/YARN-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271415#comment-16271415
 ] 

Haibo Chen commented on YARN-7581:
----------------------------------

The final HBase filter is constructed in entity readers as
A FilterList based on fields to retrieve(metricstoretrieve, configstoretrieve, 
etc)         
AND           
A FilterList based on atsv2 filters (info/conf/event/metric filters)

Attach a preliminary patch that extracts column families that are present only 
in atsv2 filters,
and adds to the fields-to-retrieve-based FilterList a FamilyFilter for each of 
them.
In the case of 
TestTimelineReaderWebServicesHBaseStorage.testGetEntitiesConfigFilters(),
the patch will generate a new HBase filter
{code}
FilterList AND (2/2): [
  FilterList AND (1/1): [
    FilterList OR (2/2): [
      SingleColumnValueFilter (c, config_param1, EQUAL, "value1"),
      SingleColumnValueFilter (c, config_param1, EQUAL, "value3")
    ]
  ],
  FilterList OR (2/2): [
    FilterList AND (5/5): [
      FamilyFilter (EQUAL, i),
      QualifierFilter (NOT_EQUAL, e!),
      QualifierFilter (NOT_EQUAL, i!),
      QualifierFilter (NOT_EQUAL, s!),
      QualifierFilter (NOT_EQUAL, r!)
    ],
    FilterList AND (1/1): [
     FamilyFilter(Equal, c) 
    ]
  ]
]
{code}

> ATSv2 does not construct HBase filters correctly in HBase 2.0
> -------------------------------------------------------------
>
>                 Key: YARN-7581
>                 URL: https://issues.apache.org/jira/browse/YARN-7581
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: ATSv2
>    Affects Versions: 3.0.0-beta1
>            Reporter: Haibo Chen
>            Assignee: Haibo Chen
>         Attachments: YARN-7581.prelim.patch
>
>
> TestTimelineReaderWebServicesHBaseStorage.testGetEntitiesConfigFilters() and 
> TestTimelineReaderWebServicesHBaseStorage.testGetEntitiesMetricFilters() 
> start to fail after we upgrade HBase to 2.0-alpha4 (To reproduce locally, 
> apply YARN-7581.prelim.patch that is attached in YARN-7346 and run the atsv2 
> unit tests)
> *Error Message*
> [ERROR] Failures:
> [ERROR]   
> TestTimelineReaderWebServicesHBaseStorage.testGetEntitiesConfigFilters:1266 
> expected:<2> but was:<0>
> [ERROR]   
> TestTimelineReaderWebServicesHBaseStorage.testGetEntitiesMetricFilters:1523 
> expected:<1> but was:<0>



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to