[ 
https://issues.apache.org/jira/browse/YARN-7565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271625#comment-16271625
 ] 

Jian He commented on YARN-7565:
-------------------------------

- onContainersFromPreviousAttempts ->  onContainersReceivedFromPreviousAttempts
To avoid compilation error of existing apps extending AMRMClientCallBack, it is 
safer to make it empty method instead of abstract method.
- ServiceConfiguration: there's a YarnServiceConf class for the configs
- ComponentInstanceEventType#RECOVER not used, can be removed
- recoveringInstances - probably no need a per component timer ? as they all 
seem start at the same time. Also, looks like the recoveringInstances will 
remain forever if there’s no container recovered for this instance later.
I think we can probably have a global reset timer in ServiceMonitor, say after 
3 min, just clear all the unrecovered instances, from then on, the previous 
containers received can be released.

> Yarn service pre-maturely releases the container after AM restart 
> ------------------------------------------------------------------
>
>                 Key: YARN-7565
>                 URL: https://issues.apache.org/jira/browse/YARN-7565
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Chandni Singh
>            Assignee: Chandni Singh
>             Fix For: yarn-native-services
>
>         Attachments: YARN-7565.001.patch
>
>
> With YARN-6168, recovered containers can be reported to AM in response to the 
> AM heartbeat. 
> Currently, the Service Master will release the containers, that are not 
> reported in the AM registration response, immediately.
> Instead, the master can wait for a configured amount of time for the 
> containers to be recovered by RM. These containers are sent to AM in the 
> heartbeat response. Once a container is not reported in the configured 
> interval, it can be released by the master.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to