[
https://issues.apache.org/jira/browse/YARN-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274342#comment-16274342
]
Sunil G commented on YARN-7586:
-------------------------------
Thanks [~suma.shivaprasad].
Few comments
# Do we need to make {{placeApplication}} and
{{replaceQueueFromPlacementContext}} static ?
# Formatting is not correct for {{placeApplication}}
# In placeApplication
{code}
789 } else{
790 LOG.error(
791 "Queue Placement Manager is null. Cannot place application :" +
" "
792 + context.getApplicationId() + " to queue ");
793 }
{code}
I think this log will be printed in cases when RM is not configured with
placement manager. This means normal submission cases. Or am i missing
something here?
# Do we need to reject or mark application submission fail instead of logging
when YarnException is thrown? Because if app cant be placed, app will fail
later, correct?
{code}
371 if (!isRecovery) {
372 try {
373 // Do queue mapping
374 placementContext = placeApplication(rmContext,
375 submissionContext, user);
376 replaceQueueFromPlacementContext(placementContext,
377 submissionContext);
378 } catch (YarnException e) {
379 String msg = "Failed to place application to queue :" +
e.getMessage();
380 LOG.error(msg, e);
381 }
{code}
> Application Placement should be done before ACL checks in ResourceManager
> -------------------------------------------------------------------------
>
> Key: YARN-7586
> URL: https://issues.apache.org/jira/browse/YARN-7586
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Suma Shivaprasad
> Assignee: Suma Shivaprasad
> Priority: Blocker
> Attachments: YARN-7586.1.patch, YARN-7586.2.patch, YARN-7586.3.patch
>
>
> YARN-7419 moved Application placement from RMAppManager to RMAppImpl which
> causes issues since ApplicationSubmissionContext still has the original queue
> specified by the user and not the mapped queue . This causes issues while
> doing ACL checks in RMAppManager
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
