[
https://issues.apache.org/jira/browse/YARN-7616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282050#comment-16282050
]
Billie Rinaldi commented on YARN-7616:
--------------------------------------
Thanks for the patch, [~gsaha]! A few comments:
* Regarding case KILLED: return ServiceState.FAILED, I was wondering how KILLED
occurs. If it means killed by the user, we might want to map it to
ServiceState.STOPPED instead.
* It doesn't look like a state is being set for running apps that are not in
STABLE state.
* Component has a state ComponentState, so I would suggest checking if this is
STABLE instead of comparing container counts. I might even suggest adding a
helper method to Component called allContainersReady (or some such) that checks
its ComponentState and ContainerStates. But I'm not sure how I feel about this
client side alteration of the Service object retrieved from the AM. Maybe we
should just be setting the Service state in the AM. [~jianhe]?
> App status does not return state STABLE for a running and stable service
> ------------------------------------------------------------------------
>
> Key: YARN-7616
> URL: https://issues.apache.org/jira/browse/YARN-7616
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Gour Saha
> Assignee: Gour Saha
> Fix For: yarn-native-services
>
> Attachments: YARN-7616.001.patch
>
>
> state currently returns null for a running and stable service. Looks like the
> code does not return ServiceState.STABLE under any circumstance. Will need to
> wire this in.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
