[ 
https://issues.apache.org/jira/browse/YARN-7555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282603#comment-16282603
 ] 

Jian He commented on YARN-7555:
-------------------------------

- In component: serviceResource -> compResource
- The name field is duplicated ?, may remove the name inside, or just make it a 
list instead.
{code}
          "resource-1": {
            "name": "resource-1",
            "value": 3333,
            "unit": "Gi"
          },
{code}
- resource_informations - information shouldn't have plural ? call it profile ?
I chatted with [~gsaha], we propose either this
{code}
        "profile": [
          {
            "name": "resource-1",
            "value": 3333,
            "unit": "Gi"
          },
          {
            "name": "yarn.io/gpu",
            "value": 5
          }
        ]
{code}
or this, and there's an existing profile field, we can modify that
{code}
        "profile": {
          "resource-1": {
            "value": 3333,
            "unit": "Gi"
          },
          "yarn.io/gpu": {
            "value": 5
          }
        }
{code}

- we can probably call amrmClient.getMatchingRequests to get all the requests 
to avoid this and the spy related code changes in MockServiceAM
{code}
 // Adding am.stop() causes test cannot be terminated when amAMRMClient is
    // spied, so here skipped stop call.
{code}


> Support multiple resource types in YARN native services
> -------------------------------------------------------
>
>                 Key: YARN-7555
>                 URL: https://issues.apache.org/jira/browse/YARN-7555
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn-native-services
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>            Priority: Critical
>         Attachments: YARN-7555.003.patch, YARN-7555.wip-001.patch
>
>
> We need to support specifying multiple resource type in addition to 
> memory/cpu in YARN native services



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to