[ 
https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286708#comment-16286708
 ] 

Jim Brennan commented on YARN-7595:
-----------------------------------

The unit test failure is the same one as before.
The checkstyle issues are fixed and the review comments have been addressed.

I think this is ready for review.

> Container launching code suppresses close exceptions after writes
> -----------------------------------------------------------------
>
>                 Key: YARN-7595
>                 URL: https://issues.apache.org/jira/browse/YARN-7595
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Jason Lowe
>            Assignee: Jim Brennan
>         Attachments: YARN-7595.001.patch, YARN-7595.002.patch, 
> YARN-7595.003.patch
>
>
> There are a number of places in code related to container launching where the 
> following pattern is used:
> {code}
>   try {
>     ...write to stream outStream...
>   } finally {
>     IOUtils.cleanupWithLogger(LOG, outStream);
>   }
> {code}
> Unfortunately this suppresses any IOException that occurs during the close() 
> method on outStream.  If the stream is buffered or could otherwise fail to 
> finish writing the file when trying to close then this can lead to 
> partial/corrupted data without throwing an I/O error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to