[ 
https://issues.apache.org/jira/browse/YARN-7643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288867#comment-16288867
 ] 

Sunil G commented on YARN-7643:
-------------------------------

Thanks [~suma.shivaprasad]

One more quick comment.
{code}
CSQueue queue = getQueue(queueName);
if (queue == null) {
         //Could be a potential auto-created leaf queue
         autoCreateQueueFromPlacementContext(applicationId, user,
                    queueName, placementContext, false);
}

if (queue == null) {
....
....
{code}

Instead of this
{code}
CSQueue queue = autoCreateQueueFromPlacementContext(applicationId, user,
                    queueName, placementContext, false);
if (queue == null) {
....
....
{code}

so from *autoCreateQueueFromPlacementContext*, call *getQueue(queueName)* and 
do necessary null checks in side. Is it ok to do?

> Handle recovery of applications on auto-created leaf queues
> -----------------------------------------------------------
>
>                 Key: YARN-7643
>                 URL: https://issues.apache.org/jira/browse/YARN-7643
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacity scheduler
>            Reporter: Suma Shivaprasad
>            Assignee: Suma Shivaprasad
>         Attachments: YARN-7643.1.patch, YARN-7643.2.patch, YARN-7643.3.patch
>
>
> CapacityScheduler application recovery should auto-create leaf queue if it 
> doesnt exist. Also RMAppManager needs to set the queue-mapping placement 
> context so that scheduler has necessary placement context to recreate the 
> queue



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to