[ 
https://issues.apache.org/jira/browse/YARN-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291230#comment-16291230
 ] 

Arun Suresh commented on YARN-7617:
-----------------------------------

Thanks for working on this [~cheersyang]..
So, I guess for this to work we need the autoupdate flag in the RM to be turned 
on - so that Container updates are sent automatically to the NM after the AM 
requests it. Which is why I think it is working for you.
We still havn't exposed a proper API to update Container in the 
NMClient/NMClientAsync (we only have updateContainerResource).
So I think we should remove this line:
{code}
999             // notify the NM
1000    nmClientAsync.updateContainerResourceAsync(container.getContainer());
{code}
And put a TODO / Note there explaining once the API is added for 
containerUpdate, we will use it - until then, we should set autoupdate on and 
let the RM automatically update the container in the next HB.


> Add a flag in distributed shell to automatically PROMOTE opportunistic 
> containers to guaranteed once they are started
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-7617
>                 URL: https://issues.apache.org/jira/browse/YARN-7617
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: applications/distributed-shell
>    Affects Versions: 2.9.0
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>            Priority: Minor
>         Attachments: YARN-7617.001.patch, promote_containers.jpg
>
>
> Per discussion in YARN-7610, it would be good to add such a flag, e.g 
> {{promote_opportunistic_after_start}}. This is for the purpose of 
> demonstrating how container promotion works.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to