[ 
https://issues.apache.org/jira/browse/YARN-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Suresh updated YARN-7670:
------------------------------
    Attachment: YARN-7670-YARN-6592.002.patch

Updating patch based on [~kkaranasos]'s suggestions.

bq. Can we unify the two createResourceCommitRequest in the CapacityScheduler 
that seem to duplicate a lot of code?
Tried this, but it turns out to be far more messy, since we have to create an 
CSAssignment for which we don't have support for SchedulingRequests. One this 
is incorporated, we can probably merge both.

bq. In the createResourceCommitRequest, since it assumes we request a single 
container in the SchedulingRequest, shouldn't we add a check for that?
I have mentioned in the javadoc for the {{attemptAllocationOnNode}} method that 
the numContainers will be ignored and the Scheduler will only try to allocate a 
single container on the requested node.

> Modifications to the ResourceScheduler to support SchedulingRequests
> --------------------------------------------------------------------
>
>                 Key: YARN-7670
>                 URL: https://issues.apache.org/jira/browse/YARN-7670
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-7670-YARN-6592.001.patch, 
> YARN-7670-YARN-6592.002.patch
>
>
> As per discussions in YARN-7612. This JIRA tracks the changes to the 
> ResourceScheduler interface and implementation in CapacityScheduler to 
> support SchedulingRequests



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to