[
https://issues.apache.org/jira/browse/YARN-6596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299436#comment-16299436
]
Arun Suresh commented on YARN-6596:
-----------------------------------
Thanks for the patch [~kkaranasos]
Skimmed through it. Couple of comments:
* Do we need both {{registerApplication()}} and {{addApplicationConstraint()}}
? The former takes a map and the latter takes individual entries of the map.
I'd say the add should be good enough - given that it exposes the replace
parameter.
* Nit: Looks like the patch introduced some empty lines.
* Given that we are dissallowing an allocation tag set key with more than 1
entry at the moment, we would also need to ensure that an incoming scheduling
request be validated to ensure it is associated with a single tag as well -
right ?
> Introduce Placement Constraint Manager module
> ---------------------------------------------
>
> Key: YARN-6596
> URL: https://issues.apache.org/jira/browse/YARN-6596
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Konstantinos Karanasos
> Assignee: Konstantinos Karanasos
> Attachments: YARN-6596-YARN-6592.001.patch
>
>
> This RM module will be responsible for storing placement constraints,
> allocation tags, and node attributes.
> It will be used when determining the placement of SchedulingRequests with
> constraints.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
