[ 
https://issues.apache.org/jira/browse/YARN-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300442#comment-16300442
 ] 

Jim Brennan commented on YARN-7678:
-----------------------------------

Did not add a new automated test because this just changes the ability to 
configure a log message separately from the other log messages in 
ContainersMonitorImpl.

Tested manually by running the TestContainersMonitorImpl and modifying the 
log4j.properties file for that test.   Verified that with no changes, no Debug 
logs are emitted.

Verified that when I add:
log4j.logger.org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainersMonitorImpl=DEBUG,
 all of the Debug logs for ContainersMonitorImpl, including the memory stat 
one, are logged.

Verified that when I add:
log4j.logger.org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainersMonitorImpl.audit=DEBUG,
 only the memory stat debug log message is logged.

Please review.

> Logging of container memory stats is missing in 2.8
> ---------------------------------------------------
>
>                 Key: YARN-7678
>                 URL: https://issues.apache.org/jira/browse/YARN-7678
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 2.8.0, 3.0.0
>            Reporter: Jim Brennan
>            Assignee: Jim Brennan
>         Attachments: YARN-7678.001.patch
>
>
> YARN-3424 changed logging of memory stats from ContainersMonitorImpl to INFO 
> to DEBUG.
> We have found these log messages to be useful information in Out-of-Memory 
> situations - they provide detail that helps show the memory profile of the 
> container over time, which can be helpful in determining root cause.
> Here's an example message from YARN-3424:
> {noformat}
> 2015-03-27 09:32:48,905 INFO 
> org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainersMonitorImpl:
>  Memory usage of ProcessTree 9215 for container-id 
> container_1427462602546_0002_01_000008: 189.8 MB of 1 GB physical memory 
> used; 2.6 GB of 2.1 GB virtual memory used
> {noformat}
> Propose to change this to use a separate logger for this message, so that we 
> can enable debug logging for this without enabling all of the other debug 
> logging for ContainersMonitorImpl.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to