[ 
https://issues.apache.org/jira/browse/YARN-6596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301583#comment-16301583
 ] 

Sunil G commented on YARN-6596:
-------------------------------

Thanks [~kkaranasos]

bq.I think we can use the same or similar API that we will use for adding 
global constraints for the node attributes. Then, we can for instance say that 
HBase containers should be on machines with java-8.Does this clarify things?
Yes. Makes sense. I have some more questions here. When global constraints are 
added, will it be possible that it may contradict with some app specific 
constraints? In that case, how app owner will know regarding same? I was 
mentioning about an interface api for app owners to get the global constrains 
and based on that place new requests. Please correct me if I understood this 
case wrongly.

bq.But maybe we could factor out some code for the file or zk implementations? 
Did you have something like this in mind?
You are correct. in-memory store has a bunch of difference. I think a ZK based 
ticket could be raised and then unify it at a later stage will be better. Since 
placement related store is not ZK now, i guess its fine for now here, and we 
can take care all managers in a common ticket (including federationstore too). 
In my mind, i was thinking of creating different tree nodes of each store and 
define a common key value pair kind of storage.

Some more comments:
# {{Map<Set<String>, PlacementConstraint> getConstraints(ApplicationId 
appId);}} looks a bit complicated return value. Its a set of allocation tags 
corresponding to one constraint, correct? In that case, do we need this to be 
in a map? Or a simple class with {{Set}} element and PlacementConstraint be 
enough?
# There are some commented code in TestMemoryPlacementConstraintManager
# Multiple source tags to one constraint is not supported in this patch, 
correct?

> Introduce Placement Constraint Manager module
> ---------------------------------------------
>
>                 Key: YARN-6596
>                 URL: https://issues.apache.org/jira/browse/YARN-6596
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Konstantinos Karanasos
>            Assignee: Konstantinos Karanasos
>         Attachments: YARN-6596-YARN-6592.001.patch, 
> YARN-6596-YARN-6592.002.patch
>
>
> This RM module will be responsible for storing placement constraints, 
> allocation tags, and node attributes.
> It will be used when determining the placement of SchedulingRequests with 
> constraints.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to