[ 
https://issues.apache.org/jira/browse/YARN-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301676#comment-16301676
 ] 

Sunil G edited comment on YARN-7612 at 12/22/17 5:14 PM:
---------------------------------------------------------

Thanks [~asuresh]
bq.That should be OK right ? if it gets cleared up, then it will be picked up 
in the next allocate call.
So code is something like this
{code}
166       public void allocate(ApplicationAttemptId appAttemptId,
167           AllocateRequest request, AllocateResponse response) throws 
YarnException {
168         List<SchedulingRequest> schedulingRequests =
169             request.getSchedulingRequests();
170         dispatchRequestsForPlacement(appAttemptId, schedulingRequests);
171         reDispatchRetryableRequests(appAttemptId);
172         schedulePlacedRequests(appAttemptId);
{code}
Here reDispatchRetryableRequests clears contents of requestsToRetry. Then 
*schedulePlacedRequests* is inturn calls addToRetryList which again picks up 
the same in one call flow? My question was to remove the second checks in 
addToRetryList method.

bq.I was hoping to handle all these efficiency improvements in a separate JIRA 
(as am sure more will pop up once we start doing scalability tests)
Yes. Makes sense to me.


was (Author: sunilg):
Thanks [~asuresh]
bq.That should be OK right ? if it gets cleared up, then it will be picked up 
in the next allocate call.
So code is something like this
{code}
166       public void allocate(ApplicationAttemptId appAttemptId,
167           AllocateRequest request, AllocateResponse response) throws 
YarnException {
168         List<SchedulingRequest> schedulingRequests =
169             request.getSchedulingRequests();
170         dispatchRequestsForPlacement(appAttemptId, schedulingRequests);
171         reDispatchRetryableRequests(appAttemptId);
172         schedulePlacedRequests(appAttemptId);
{code}
Here reDispatchRetryableRequests clears contents of requestsToRetry. Then 
*schedulePlacedRequests* is inturn calls addToRetryList which again picks up 
the same in one call flow? My question was to remove the second checks in 
addToRetryList method.

> Add Placement Processor Framework
> ---------------------------------
>
>                 Key: YARN-7612
>                 URL: https://issues.apache.org/jira/browse/YARN-7612
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-7612-YARN-6592.001.patch, 
> YARN-7612-YARN-6592.002.patch, YARN-7612-YARN-6592.003.patch, 
> YARN-7612-YARN-6592.004.patch, YARN-7612-YARN-6592.005.patch, 
> YARN-7612-YARN-6592.006.patch, YARN-7612-YARN-6592.007.patch, 
> YARN-7612-YARN-6592.008.patch, YARN-7612-YARN-6592.009.patch, 
> YARN-7612-YARN-6592.010.patch, YARN-7612-v2.wip.patch, YARN-7612.wip.patch
>
>
> This introduces a Placement Processor and a Planning algorithm framework to 
> handle placement constraints and scheduling requests from an app and places 
> them on nodes.
> The actual planning algorithm(s) will be handled in a YARN-7613.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to