[
https://issues.apache.org/jira/browse/YARN-7613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303327#comment-16303327
]
Panagiotis Garefalakis edited comment on YARN-7613 at 12/25/17 5:28 PM:
------------------------------------------------------------------------
Thanks for the comments [~asuresh]
bq. Based on discussions in YARN-7612, Lets move the canAssign method into a
separate utility class and handle that in YARN-7681.
It should definitely be in a separate class but I am not sure it should be a
utility one. It is part of constraint satisfaction so it looks quite
fundamental to me - in a previous draft patch I had the method as part of the
constraint manager for example which did make some sense.
bq. At the very least, it should take the container source tags (from the
SchedulingRequest), the target SchedulerNode, the TagsManager and the
ConstraintsManager - and return true if it can assign the source tag to the
Scheduler node without violating any constraints.
ApplicationId is also needed since we query the tags based on that but I agree
about the rest - would also pass the SchedulingRequest object instead of tags
as they contain more information.
AlgorithmContext (described in your previous comment) could be helpful in this
as well since we would not have to pass Tags and Constraints Managers
explicitly.
was (Author: pgaref):
bq. Based on discussions in YARN-7612, Lets move the canAssign method into a
separate utility class and handle that in YARN-7681.
It should definitely be in a separate class but I am not sure it should be a
utility one. It is part of constraint satisfaction so it looks quite
fundamental to me - in a previous draft patch I had the method as part of the
constraint manager for example which did make some sense.
bq. At the very least, it should take the container source tags (from the
SchedulingRequest), the target SchedulerNode, the TagsManager and the
ConstraintsManager - and return true if it can assign the source tag to the
Scheduler node without violating any constraints.
ApplicationId is also needed since we query the tags based on that but I agree
about the rest - would also pass the SchedulingRequest object instead of tags
as they contain more information.
AlgorithmContext (described in your previous comment) could be helpful in this
as well since we would not have to pass Tags and Constraints Managers
explicitly.
> Implement Planning algorithms for rich placement
> ------------------------------------------------
>
> Key: YARN-7613
> URL: https://issues.apache.org/jira/browse/YARN-7613
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Panagiotis Garefalakis
> Attachments: YARN-7613.wip.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
