[
https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305684#comment-16305684
]
Konstantinos Karanasos commented on YARN-7682:
----------------------------------------------
Hi guys,
I am on the phone (traveling For the next few days), so I cannot check the
code, but a few comments.
* Are these intra-application only checks?
* The problem Panagiotis describes with affinity seems to happen only when the
source tag is the same as the target tag. If it is not, then the canAssign
should fail no matter whether it is the first allocation. So I think these two
cases should be distinguished.
* affinity with more than 2 in cmin is actually a cardinality constraint. I
don’t think we still call it affinity (but I might not remember well). If
that’s the case we can have both min and max cardinalities.
* At the moment we only check satisfiability of a container at a time. If the
api could allow multiple containers, the affinity problem might not be there.
As in I want 5 spark containers.
I am fine pushing a first version where not all these are in, so that we can
test a first end-to-end scenario, but some of the above comments should be
considered, especially the second one.
> Expose canAssign method in the PlacementConstraintManager
> ---------------------------------------------------------
>
> Key: YARN-7682
> URL: https://issues.apache.org/jira/browse/YARN-7682
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Panagiotis Garefalakis
> Attachments: YARN-7682-YARN-6592.001.patch, YARN-7682.wip.patch
>
>
> As per discussion in YARN-7613. Lets expose {{canAssign}} method in the
> PlacementConstraintManager that takes a sourceTags, applicationId,
> SchedulerNode and AllocationTagsManager and returns true if constraints are
> not violated by placing the container on the node.
> I prefer not passing in the SchedulingRequest, since it can have > 1
> numAllocations. We want this api to be called for single allocations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
