[
https://issues.apache.org/jira/browse/YARN-7666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306599#comment-16306599
]
Wangda Tan commented on YARN-7666:
----------------------------------
Thanks [~sunilg] for working on this JIRA.
In general, the patch looks good since it can let the client select scheduling
policies without modifying any application code.
Some suggestions:
1) It's better to move
{code}
66 @InterfaceAudience.Private
67 public static final String ENV_APPLICATION_PLACEMENT_TYPE_CLASS =
68 "APPLICATION_PLACEMENT_TYPE_CLASS";
69
70 @InterfaceAudience.Private
71 public static final Class<? extends AppPlacementAllocator>
72 DEFAULT_APPLICATION_PLACEMENT_TYPE_CLASS =
LocalityAppPlacementAllocator.class;
{code}
To a new class such as ApplicationSchdudlingConfig. (which can locate inside
rm.scheduler.common) package temporarily instead of exposing to end user.
2) Regarding the naming of the field. Instead of naming it {{*environment}}, I
would prefer to call it properties or hints to avoid people think it is a
process environment which will be passed to AM process.
For comment from [~asuresh], it makes sense to let the client notify AM about
whatever required. A simple way of doing this (without changing YARN framework
code) is to either set hints to AM's environment or Java launch properties. To
make it generic, we can also include a copy of ApplicationSubmissionContext to
RegisterAMResponse or a new data structure just for scheduling hints. In any
case, I would suggest to move these changes to a separate JIRA.
> Introduce scheduler specific environment variable support in ASC for better
> scheduling placement configurations
> ---------------------------------------------------------------------------------------------------------------
>
> Key: YARN-7666
> URL: https://issues.apache.org/jira/browse/YARN-7666
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Sunil G
> Assignee: Sunil G
> Attachments: YARN-7666.001.patch, YARN-7666.002.patch
>
>
> Introduce a scheduler specific key-value map to hold env variables in ASC.
> And also convert AppPlacementAllocator initialization to each app based on
> policy configured at each app.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
