[
https://issues.apache.org/jira/browse/YARN-7687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306907#comment-16306907
]
BELUGA BEHR edited comment on YARN-7687 at 12/30/17 6:40 PM:
-------------------------------------------------------------
[[email protected]] I was assuming that anyone interested in this
Appender was interested in using it because it has this buffering capability.
There's not really a reason to use if you're not using the buffer. Always
creating the buffer makes it easier elsewhere in the code because no 'null'
checks are required seeing as it will always exist.
However, I have updated the patch with the lazy creation.
was (Author: belugabehr):
[[email protected]] I was assuming that anyone interested in this
Appender was interested in using it because it has this buffering capability.
There's not real reason to use if you're not using the buffer. Always creating
the buffer makes it easier elsewhere in the code because no 'null' checks are
required seeing as it will always exist.
However, I have updated the patch with the lazy creation.
> ContainerLogAppender Improvements
> ---------------------------------
>
> Key: YARN-7687
> URL: https://issues.apache.org/jira/browse/YARN-7687
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: BELUGA BEHR
> Priority: Trivial
> Attachments: YARN-7687.1.patch, YARN-7687.2.patch
>
>
> * Use Array-backed collection instead of LinkedList
> * Ignore calls to {{close()}} after the initial call
> * Clear the queue after {{close}} is called to let garbage collection do its
> magic on the items inside of it
> * Fix int-to-long conversion issue (overflow)
> * Remove superfluous white space
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
