[
https://issues.apache.org/jira/browse/YARN-6599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wangda Tan updated YARN-6599:
-----------------------------
Attachment: YARN-6599-YARN-6592.007.patch
Thanks [~sunilg] for reviewing the patch.
For 1. I thought about this, I just moved it inside PlacementConstraints,
please let me know if that looks better.
For 2. Done.
For 3. Done.
For 4. Because we don't want to app to add old ResourceRequests to this
allocator. I should put this in exception message already.
For 5. Given the scope of this patch, I suggest doing minor refactorings when
we need 2nd AppPlacementAllocator for scheduling request.
For 6/7. This check is actually check if a updated SchedulingRequest has
everything same as previously added request except #allocations. A simple way
is to set the new SchedulingRequest's #allocation same as existing one and roll
back after comparison. I improved the check a bit to return null when the new
added scheduling-request is exactly same as existing one.
For 8. Done
For 9. I prefer to keep validation here since different app placement allocator
could support different subset of SchedulingRequest features. I moved the
validation node logic to PlacementConstraintUtils.
For 10. No we don't allow change anything except #allocations. app can cancel
the previous request by setting #allocation to 0. And request a new
SchedulingRequest with different SchedulerKey.
For 11. No we cannot, because we can have normal target allocation tags like
"mapper"
For 12. That's the own app's id, inside the allocation tags of
TargetExpression, app can specify different app's id to anti-affinity to.
Uploaded ver.7 patch to see what if breaks.
> Support rich placement constraints in scheduler
> -----------------------------------------------
>
> Key: YARN-6599
> URL: https://issues.apache.org/jira/browse/YARN-6599
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-6599-YARN-6592.003.patch,
> YARN-6599-YARN-6592.004.patch, YARN-6599-YARN-6592.005.patch,
> YARN-6599-YARN-6592.006.patch, YARN-6599-YARN-6592.007.patch,
> YARN-6599-YARN-6592.wip.002.patch, YARN-6599.poc.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
