[
https://issues.apache.org/jira/browse/YARN-7696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arun Suresh updated YARN-7696:
------------------------------
Attachment: YARN-7696-YARN-6592.001.patch
Attaching initial patch.
I refactored the ContainerTokenIdentifier class to remove all the constructors
and moved it to a separate builder class as static create methods and marked
them as @VisibileForTesting. For the following reasons:
* The ConatinerTokenIdentifier should have only 1 way to create it. The clients
of the constructor MUST be forced to explicitly specify all the fields. This
reduces confusion since you don't have to worry about which constructor must be
called.
* I also noticed that only Tests use the other constructors. Thus they should
be all moved to a utlity class useed by the test cases. Unfortunately, there
are tests in other packages that need to create COntainerTokenIdentifies, Thus
I had to keep the new builder in the src/main folder.
The patch itself is pretty trivial. The size is due to the above refactoring.
[~kkaranasos] / [~leftnoteasy] / [~sunilg], can you give this a quick look ?
This is needed for the AMRMClient changes as well.
> Add container tags to ContainerTokenIdentifier, api.Container and
> NMContainerStatus to handle all recovery cases
> ----------------------------------------------------------------------------------------------------------------
>
> Key: YARN-7696
> URL: https://issues.apache.org/jira/browse/YARN-7696
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-7696-YARN-6592.001.patch
>
>
> The NM needs to persist the Container tags so that on RM recovery, it is sent
> back to the RM via the NMContainerStatus. The RM would then recover the
> AllocationTagsManager using this information.
> The api.Container also requires the allocationTags since after AM recovery,
> we need to provide the AM with previously allocated containers.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
