[
https://issues.apache.org/jira/browse/YARN-6599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314152#comment-16314152
]
Arun Suresh commented on YARN-6599:
-----------------------------------
[~leftnoteasy], thanks for working on this. Couple of comments:
* I think you should keep the name of the main entry point method as
{{canSatisfyConstraints}}. The single constraint is a special case and you can
have a private method for it, once we decide in the above function that the
constraint is a single constraint type.
* Shouldnt you have to do the checkMinCardinality in all cases ?
* Can we split the node-partition target expression handling aspect into a
separate JIRA maybe ?
* To check if the given constraint is a SingleConstraint, you should use the
transformer first before doing a type cast.
* Can we target this JIRA for just intra-app anti-affinity. I am also not
really sold on the application-id/allocation-tag format yet. It requires that
the first app be running and then the second app (since we wont have a
application-Id till then) - Also if we couple this with application priorities,
I can think of a situation where we can deadlock.
> Support rich placement constraints in scheduler
> -----------------------------------------------
>
> Key: YARN-6599
> URL: https://issues.apache.org/jira/browse/YARN-6599
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-6599-YARN-6592.003.patch,
> YARN-6599-YARN-6592.004.patch, YARN-6599-YARN-6592.005.patch,
> YARN-6599-YARN-6592.006.patch, YARN-6599-YARN-6592.007.patch,
> YARN-6599-YARN-6592.008.patch, YARN-6599-YARN-6592.wip.002.patch,
> YARN-6599.poc.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
