[
https://issues.apache.org/jira/browse/YARN-7696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321253#comment-16321253
]
Wangda Tan commented on YARN-7696:
----------------------------------
Thanks [~asuresh], just took a look at the patch.
1) ContainerTokenIdentifier, this is public/evolving. I understand that bylaw
it is allowed however the truth is downstream projects sometimes treat evolving
same as stable (we saw examples in Hive/Spark). To avoid painful of downstream
project, I suggest to
- Keep the original constructor, and mark it to be deprecated.
- Mark the new getAllcationTags to Unstable. (I'm doubt if application needs to
read any fields from token identifier as we already have information in
Container)
2) Unused imports in:
- RMContainerTokenSecretManager
> Add container tags to ContainerTokenIdentifier, api.Container and
> NMContainerStatus to handle all recovery cases
> ----------------------------------------------------------------------------------------------------------------
>
> Key: YARN-7696
> URL: https://issues.apache.org/jira/browse/YARN-7696
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-7696-YARN-6592.001.patch,
> YARN-7696-YARN-6592.002.patch, YARN-7696-YARN-6592.003.patch
>
>
> The NM needs to persist the Container tags so that on RM recovery, it is sent
> back to the RM via the NMContainerStatus. The RM would then recover the
> AllocationTagsManager using this information.
> The api.Container also requires the allocationTags since after AM recovery,
> we need to provide the AM with previously allocated containers.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
