[
https://issues.apache.org/jira/browse/YARN-7064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321513#comment-16321513
]
Miklos Szegedi commented on YARN-7064:
--------------------------------------
Thank you for the review, [~haibochen].
bq. 1) Why are we skipping NM_MEMORY_RESOURCE_PREFIX configurations in
TestYarnConfigurationFields now?
Because we actually add the documentation that triggered the test failure that
required these ignores.
bq. 3) In ProcfsBasedProcessTree.java, do we also want to print out the clock
time as well besides the total jiffies? If so, it appears to me that
CpuTimeTracker. updateElapsedJiffies() is a more appropriate place to log.
Does not log4j has the option to print out the time? CpuTimeTracker does not
have any logging. I would defer this to another jira, if someone actually needs
it.
bq. 4) TestCompareResourceCalculators is more of a functional test. Can we add
in the class javadoc what its purpose is and why it is ignored by default in
the code?
It was already documented later in the code but I added to the same
notification to the class javadoc as well per request.
5)
I like the name CombinedResourceCalculator. It is slower indeed but I am not so
convinced that it is actually not so accurate as ProcfsBasedProcessTree.
6)
In CGroupsResourceCalculator, processFile() cannot be static since it refers
to pid from the actual object that helps debugging.
> Use cgroup to get container resource utilization
> ------------------------------------------------
>
> Key: YARN-7064
> URL: https://issues.apache.org/jira/browse/YARN-7064
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Miklos Szegedi
> Assignee: Miklos Szegedi
> Attachments: YARN-7064.000.patch, YARN-7064.001.patch,
> YARN-7064.002.patch, YARN-7064.003.patch, YARN-7064.004.patch,
> YARN-7064.005.patch, YARN-7064.007.patch, YARN-7064.008.patch,
> YARN-7064.009.patch, YARN-7064.010.patch
>
>
> This is an addendum to YARN-6668. What happens is that that jira always wants
> to rebase patches against YARN-1011 instead of trunk.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
