[
https://issues.apache.org/jira/browse/YARN-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Badger updated YARN-7717:
------------------------------
Attachment: YARN-7717.003.patch
bq. The default for tc should still be false.
Wow, that's a pretty bad mistake. Thanks for the catch
bq. There is and indentation issue on the last line.
Fixed. I'm pretty confused on indentation rules in C code for hadoop. It
appears that the code doesn't follow the same rules as Java hadoop code. In
container-executor.c, a bunch of if statements have the following lines
indented 4 spaces, while it's only 2 in docker-util.c. Looks like the culprit
might just be inconsistency in container-executor.c not always following the
same rules as Java hadoop code.
> Add configuration consistency for module.enabled and
> docker.privileged-containers.enabled
> -----------------------------------------------------------------------------------------
>
> Key: YARN-7717
> URL: https://issues.apache.org/jira/browse/YARN-7717
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Yesha Vora
> Assignee: Eric Badger
> Attachments: YARN-7717.001.patch, YARN-7717.002.patch,
> YARN-7717.003.patch
>
>
> container-executor.cfg has two properties related to dockerization.
> 1) module.enabled = true/false
> 2) docker.privileged-containers.enabled = 1/0
> Here, both property takes different value to enable / disable feature. Module
> enabled take true/false string while docker.privileged-containers.enabled
> takes 1/0 integer value.
> This properties behavior should be consistent. Both properties should have
> true or false string as value to enable or disable feature/
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
