[
https://issues.apache.org/jira/browse/YARN-7451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323865#comment-16323865
]
Gergo Repas commented on YARN-7451:
-----------------------------------
Thanks [~snemeth] for the patch. A couple of comments:
# You documented the motivation behind the serialization-related changes at
some locations (etc. in ResourceInfoWithCustomResourceTypes), but would be
useful to add some explanation to other locations. For example:
## ResourceManager.startWepApp() when setting the IteratorProvider
## JAXBContextResolver.ECLIPSELINK_SERIALIZED_TYPES - some comment would be
useful why these classes need special handling (maybe even a short example).
## in the resourcemanager's pom.xml - where you're adding the new dependency
# SchedulerInfo.getMaxClusterLevelAppPriority() - please add a comment what's
the reason for adding @XmlTransient
# In some classes imports are changed without any logic change, etc: RMWebApp,
TestRMWebServicesConfigurationMutation
# ArrayElementPathSegment.extractIndex() - when input does not match pattern -
this case is not handled
# There are outstanding checkstyle, license and javadoc issues
> Resources Types should be visible in the Cluster Apps API "resourceRequests"
> section
> ------------------------------------------------------------------------------------
>
> Key: YARN-7451
> URL: https://issues.apache.org/jira/browse/YARN-7451
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager, restapi
> Affects Versions: 3.0.0
> Reporter: Grant Sohn
> Assignee: Szilard Nemeth
> Attachments: YARN-7451.001.patch, YARN-7451.002.patch,
> YARN-7451.003.patch, YARN-7451.004.patch, YARN-7451.005.patch,
> YARN-7451__Expose_custom_resource_types_on_RM_scheduler_API_as_flattened_map01_02.patch
>
>
> When running jobs that request resource types the RM Cluster Apps API should
> include this in the "resourceRequests" object.
> Additionally, when calling the RM scheduler API it returns:
> {noformat}
> "childQueues": {
> "queue": [
> {
> "allocatedContainers": 101,
> "amMaxResources": {
> "memory": 320390,
> "vCores": 192
> },
> "amUsedResources": {
> "memory": 1024,
> "vCores": 1
> },
> "clusterResources": {
> "memory": 640779,
> "vCores": 384
> },
> "demandResources": {
> "memory": 103424,
> "vCores": 101
> },
> "fairResources": {
> "memory": 640779,
> "vCores": 384
> },
> "maxApps": 2147483647,
> "maxResources": {
> "memory": 640779,
> "vCores": 384
> },
> "minResources": {
> "memory": 0,
> "vCores": 0
> },
> "numActiveApps": 1,
> "numPendingApps": 0,
> "preemptable": true,
> "queueName": "root.users.systest",
> "reservedContainers": 0,
> "reservedResources": {
> "memory": 0,
> "vCores": 0
> },
> "schedulingPolicy": "fair",
> "steadyFairResources": {
> "memory": 320390,
> "vCores": 192
> },
> "type": "fairSchedulerLeafQueueInfo",
> "usedResources": {
> "memory": 103424,
> "vCores": 101
> }
> }
> ]
> {noformat}
> However, the web UI shows resource types usage.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
