[ 
https://issues.apache.org/jira/browse/YARN-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13750240#comment-13750240
 ] 

Karthik Kambatla commented on YARN-1027:
----------------------------------------

Thanks for the review, Bikas. Sorry for the delay in response - was on vacation 
last week.

bq. Taking the hybrid approach drops the simplicity of the wrapper while at the 
same time making it complex to interact with the ResourceManager.
I see your point. IMO, the extension approach increases the flexibility of the 
wrapper approach without adding too much complexity. Keeping the HA code 
separate from the RM avoids complicating the RM, particularly during the period 
we are stabilizing the HA portion of the code. Once stable, if we think it is 
appropriate, it is simple enough to merge it all into the RM itself.

bq. Which one is the real ResourceManager. For example, there are many tests 
that use the ResourceManager but now since they dont use HAResourceManager they 
are probably not exercising some possibilities. Should they use 
HAResourceManager?
The HA specific tests can access the HAResourceManager, it should be okay for 
the remaining tests to access ResourceManager and not the HAResourceManager.

bq. This shows that adding HA awareness can be added without significant 
overhaul in the RM.
Most importantly, my fear is adding HA to the RM directly leads to a more 
significant overhaul.

Let me draft a patch implementing the same within RM itself instead of 
extending it. Any other ideas in the interim would also greatly help.

                
> Implement RMHAServiceProtocol
> -----------------------------
>
>                 Key: YARN-1027
>                 URL: https://issues.apache.org/jira/browse/YARN-1027
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Karthik Kambatla
>         Attachments: yarn-1027-1.patch
>
>
> Implement existing HAServiceProtocol from Hadoop common. This protocol is the 
> single point of interaction between the RM and HA clients/services.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to