[
https://issues.apache.org/jira/browse/YARN-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328829#comment-16328829
]
Wilfred Spiegelenburg edited comment on YARN-7139 at 1/17/18 2:33 PM:
----------------------------------------------------------------------
The comment does not mean that the tests are not good enough. The remark is
that during the tests when we get into the {{addApplication}} method we have
not initialised all objects in the FairScheduler since they are not needed to
test the behaviours we need to test.
You can add an application to the scheduler without a {{rmApp}} object. If we
add a {{rmApp}} object we also need to add the application submission context
to it. That adds a lot of overhead. Fixing all the tests (see the list in
[first QA comment|
https://issues.apache.org/jira/browse/YARN-7139?focusedCommentId=16148467&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16148467])
would be nice but does not improve what we test and makes maintaining the
tests far more difficult.
was (Author: wilfreds):
The comment does not mean that the tests are not good enough. The remark is
that during the tests when we get into the {{addApplication}} method we have
not initialised all objects in the FairScheduler since they are not needed to
test the behaviours we need to test.
You can add an application to the scheduler without an {{rmApp}} object. If we
add an {{rmApp}} object we also need to add the application submission context
to it. That adds a lot of overhead. Fixing all the tests (see the list in
[first QA comment|
https://issues.apache.org/jira/browse/YARN-7139?focusedCommentId=16148467&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16148467])
would be nice but does not improve what we test and makes maintaining the
tests far more difficult.
> FairScheduler: finished applications are always restored to default queue
> -------------------------------------------------------------------------
>
> Key: YARN-7139
> URL: https://issues.apache.org/jira/browse/YARN-7139
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Affects Versions: 2.8.1
> Reporter: Wilfred Spiegelenburg
> Assignee: Wilfred Spiegelenburg
> Priority: Major
> Attachments: YARN-7139.01.patch, YARN-7139.02.patch,
> YARN-7139.03.patch, YARN-7139.04.patch
>
>
> The queue an application gets submitted to is defined by the placement policy
> in the FS. The placement policy returns the queue and the application object
> is updated. When an application is stored in the state store the application
> submission context is used which has not been updated after the placement
> rules have run.
> This means that the original queue from the submission is still stored which
> is the incorrect queue. On restore we then read back the wrong queue and
> display the wrong queue in the RM web UI.
> We should update the submission context after we have run the placement
> policies to make sure that we store the correct queue for the application.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
