[ https://issues.apache.org/jira/browse/YARN-7729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329456#comment-16329456 ]
Billie Rinaldi commented on YARN-7729: -------------------------------------- Thanks for the review, [~shaneku...@gmail.com]! I am working on a patch that addresses your suggestions. It seems like I will need to wait until after YARN-7717 is committed to be able to use the same check for true that is introduced in that patch. Regarding the formatting change in TestDockerContainerRuntime, I added that because the old formatting produced 2 checkstyle errors for the first patch I submitted. > Add support for setting the PID namespace mode > ---------------------------------------------- > > Key: YARN-7729 > URL: https://issues.apache.org/jira/browse/YARN-7729 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager > Reporter: Shane Kumpf > Assignee: Billie Rinaldi > Priority: Major > Attachments: YARN-7729.001.patch, YARN-7729.002.patch > > > Docker has support for allowing containers to share the PID namespace with > the host or other containers via the {{docker run --pid}} flag. > There are a number of use cases where this is desirable: > * Monitoring tools running in containers that need access to the host level > PIDs. > * Debug containers that can attach to another container to run strace, gdb, > etc. > * Testing Docker on YARN in a container, where the docker socket is bind > mounted. > Enabling this feature should be considered privileged as it exposes host > details inside the container. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org