[ 
https://issues.apache.org/jira/browse/YARN-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336014#comment-16336014
 ] 

Miklos Szegedi commented on YARN-5473:
--------------------------------------

Thank you, [~haibochen]!

The latest patch have a few checkstyle issues that would not make the patch 
noticeably bigger:
{code}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java:1419:
                    usageReport.setGuaranteedMemorySeconds(memorySeconds);: 
'method def' child have incorrect indentation level 20, expected level should 
be one of the following: 12, 14, 16. [Indentation]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java:1420:
                    usageReport.setGuaranteedVcoreSeconds(vcoreSeconds);: 
'method def' child have incorrect indentation level 20, expected level should 
be one of the following: 12, 14, 16. [Indentation]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestContainerResourceUsage.java:290:
  private void amRestartTests(boolean keepRunningContainers):3: Method length 
is 156 lines (max allowed is 150). [MethodLength]
{code}

> Expose per-application over-allocation info in the Resource Manager
> -------------------------------------------------------------------
>
>                 Key: YARN-5473
>                 URL: https://issues.apache.org/jira/browse/YARN-5473
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Haibo Chen
>            Priority: Major
>         Attachments: YARN-5473-YARN-1011.00.patch, 
> YARN-5473-YARN-1011.01.patch, YARN-5473-YARN-1011.02.patch, 
> YARN-5473-YARN-1011.prelim.patch
>
>
> When enabling over-allocation of nodes, the resources in the cluster change. 
> We need to surface this information for users to understand these changes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to