[ 
https://issues.apache.org/jira/browse/YARN-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346250#comment-16346250
 ] 

Wangda Tan commented on YARN-7739:
----------------------------------

Thanks [~sunilg]/[~templedf] for review: 
{quote}It would be nice to have the test not hard-coded to CS
{quote}
I just updated test to cover both, but not a parameterized unit test, IIRC, 
parameterized unit test need to be a separate class and sometimes it will be 
hard to debug in IDE in my past experiences. Please check if the updated patch 
looks good to you. [~templedf]

> DefaultAMSProcessor should properly check customized resource types against 
> minimum/maximum allocation
> ------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-7739
>                 URL: https://issues.apache.org/jira/browse/YARN-7739
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>            Priority: Blocker
>         Attachments: YARN-7339.002.patch, YARN-7739.001.patch
>
>
> Currently, YARN RM reject requested resource if memory or vcores are less 
> than 0 or greater than maximum allocation. We should run the check for 
> customized resource types as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to