[
https://issues.apache.org/jira/browse/YARN-7849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347559#comment-16347559
]
Jason Lowe commented on YARN-7849:
----------------------------------
Thanks for the patch!
I'm worried that this test is still fragile even after the fix. The unit test
stands up a minicluster and attempts to asynchronously simulate a node
heartbeat. Maybe I'm missing something, but the minicluster is going to be
automatically heartbeating during this test, and at some random time some
external heartbeat will be injected into the ResourceTrackerService in the RM.
If the "normal" heartbeating of the minicluster node happens at just the right
(or wrong) time then I think the sequence number could still be off and fail
this test.
IMHO the test should not be using a full minicluster at all if it needs to
carefully control the node heartbeats. It should stand up as much of the RM as
it needs then manually inject the mock heartbeats. Letting a "real"
nodemanager continue heartbeating asynchronously to the mocked heartbeats is
going to be racy.
> TestMiniYarnClusterNodeUtilization#testUpdateNodeUtilization fails due to
> heartbeat sync error
> ----------------------------------------------------------------------------------------------
>
> Key: YARN-7849
> URL: https://issues.apache.org/jira/browse/YARN-7849
> Project: Hadoop YARN
> Issue Type: Bug
> Components: test
> Affects Versions: 3.1.0, 2.9.1, 3.0.1, 2.8.4
> Reporter: Jason Lowe
> Assignee: Botong Huang
> Priority: Major
> Attachments: YARN-7849-branch-2.8.v1.patch, YARN-7849.v1.patch
>
>
> testUpdateNodeUtilization is failing. From a branch-2.8 run:
> {noformat}
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 13.013 sec
> <<< FAILURE! - in
> org.apache.hadoop.yarn.server.TestMiniYarnClusterNodeUtilization
> testUpdateNodeUtilization(org.apache.hadoop.yarn.server.TestMiniYarnClusterNodeUtilization)
> Time elapsed: 12.961 sec <<< FAILURE!
> java.lang.AssertionError: Containers Utillization not propagated to RMNode
> expected:<<pmem:1024, vmem:2048, vCores:11.0>> but was:<null>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at
> org.apache.hadoop.yarn.server.TestMiniYarnClusterNodeUtilization.verifySimulatedUtilization(TestMiniYarnClusterNodeUtilization.java:227)
> at
> org.apache.hadoop.yarn.server.TestMiniYarnClusterNodeUtilization.testUpdateNodeUtilization(TestMiniYarnClusterNodeUtilization.java:116)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
