[ https://issues.apache.org/jira/browse/YARN-7838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350798#comment-16350798 ]
Arun Suresh commented on YARN-7838: ----------------------------------- Thanks for taking a stab at this [~cheersyang]. Yup, I agree we need a more flexible parser - the placementspec parser I put in was just for some adhoc testing :) Couple of comments: # do we need a tryParse ? Either we are able to parse or an exception is thrown right ? # The {{toInt}} should be static # I am assuming your {{shouldHaveNext}} is more like an assert - Maybe make that static as well, and # In the final implementation, we have to ensure that it accepts a placementspec string WITHOUT any and/or as well. > Support AND/OR constraints in Distributed Shell > ----------------------------------------------- > > Key: YARN-7838 > URL: https://issues.apache.org/jira/browse/YARN-7838 > Project: Hadoop YARN > Issue Type: Sub-task > Components: distributed-shell > Reporter: Weiwei Yang > Assignee: Weiwei Yang > Priority: Major > Attachments: YARN-7838.prelim.patch > > > Extending DS placement spec syntax to support AND/OR constraints, something > like > {code} > // simple > -placement_spec foo=4,AND(NOTIN,NODE,foo:NOTIN,NODE,bar) > // nested > -placement_spec foo=4,AND(NOTIN,NODE,foo:OR(IN,NODE,moo:IN,NODE,bar)) > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org