[
https://issues.apache.org/jira/browse/YARN-7815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351410#comment-16351410
]
Shane Kumpf commented on YARN-7815:
-----------------------------------
Attached a patch to address the unit test failures.
I'm hesitant to fix these two check style issues as I don't believe it improves
the code by doing so, but I also don't like adding new check style issues. Let
me know your thoughts. Does it make sense to even have this check style rule?
{code:java}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/executor/ContainerStartContext.java:142:
public Builder setUserFilecacheDirs(List<String> userFilecacheDirs) {:54:
'userFilecacheDirs' hides a field. [HiddenField]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/executor/ContainerStartContext.java:147:
public Builder setApplicationLocalDirs(List<String> applicationLocalDirs)
{:57: 'applicationLocalDirs' hides a field. [HiddenField]{code}
> Mount the filecache as read-only in Docker containers
> -----------------------------------------------------
>
> Key: YARN-7815
> URL: https://issues.apache.org/jira/browse/YARN-7815
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Shane Kumpf
> Assignee: Shane Kumpf
> Priority: Major
> Attachments: YARN-7815.001.patch, YARN-7815.002.patch
>
>
> Currently, when using the Docker runtime, the filecache directories are
> mounted read-write into the Docker containers. Read write access is not
> necessary. We should make this more restrictive by changing that mount to
> read-only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
