[ 
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355204#comment-16355204
 ] 

Sunil G commented on YARN-7871:
-------------------------------

Thanks [~cheersyang]

Some comments in general:
 # With this patch, NM could be configured either for 
CONFIG_NODE_DESCRIPTOR_PROVIDER or SCRIPT_NODE_DESCRIPTOR_PROVIDER? It could be 
possible that there are some static configs for any node and some additional 
attributes could be later added from scripts?
 # In {{createNodeAttributesProvider}} i am not very clear about the default 
case handling. We could through an error when config/scripts is not given 
correct?
 # Is RMNodeAttributesManager need to part of this jira? Because i think that 
manager needs to handle all 3 types of attributes, so I am not very sure 
whether this is now a placeholder or not? Could you please confirm

> Node attributes reporting from NM to RM 
> ----------------------------------------
>
>                 Key: YARN-7871
>                 URL: https://issues.apache.org/jira/browse/YARN-7871
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>            Priority: Major
>         Attachments: YARN-7871-YARN-3409.001.patch
>
>
> Support to initialize proper attribute provider based on user's configuration.
> NM collects node attributes from a configured attribute provider and send 
> them to RM via HB. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to