[ 
https://issues.apache.org/jira/browse/YARN-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753278#comment-13753278
 ] 

Jian He commented on YARN-1107:
-------------------------------

Patch looks fine. Few comments:

No need to add this method 'compareRMToken' to compare Token set.The following 
is from JAVA Doc regarding set.equals():
Returns true if the specified object is also a set, the two sets have the same 
size, and every member of the specified set is contained in this set (or 
equivalently, every member of this set is contained in the specified set)

So internally it should compare each member of each sets automatically and 
AbstractDelegationTokenIdentifier implements its own equals() already.

TestSecurityMockRM.serviceInit(): the whole method can be removed.


                
> Job submitted with Delegation token in secured environment causes RM to fail 
> during RM restart
> ----------------------------------------------------------------------------------------------
>
>                 Key: YARN-1107
>                 URL: https://issues.apache.org/jira/browse/YARN-1107
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.1.0-beta
>            Reporter: Arpit Gupta
>            Assignee: Omkar Vinit Joshi
>            Priority: Blocker
>         Attachments: rm.log, YARN-1107.20130828.1.patch
>
>
> If secure RM with recovery enabled is restarted while oozie jobs are running 
> rm fails to come up.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to