[ 
https://issues.apache.org/jira/browse/YARN-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356173#comment-16356173
 ] 

Naganarasimha G R edited comment on YARN-7892 at 2/7/18 10:30 PM:
------------------------------------------------------------------

Agree with you and after i proceeded with the YARN-6858 (Attribute Impl 
Manager) and YARN-7856 (Validate node Attributes), I realised that type is just 
a characteristic of the Attribute and actually name and prefix is what is 
uniquely identifying it from others. Else in every place we need to separately 
start storing with Name and prefix what are the attributes for example 7856 is 
newly introducing a map to just compare whether any duplicates exists. 


was (Author: naganarasimha):
Agree with you and after i proceeded with the AttributeImpl Manager and 
YARN-7856 (Validate node Attributes), I realised that type is just a 
characteristic of the Attribute and actually name and prefix is what is 
uniquely identifying it. Else in every place we need to separately start 
storing with Name and prefix what are the attributes. Hence i am modifying this 
patch again to just consider the name and prefix for equals and hash code 
identification. 

> NodeAttributePBImpl does not implement hashcode and Equals properly
> -------------------------------------------------------------------
>
>                 Key: YARN-7892
>                 URL: https://issues.apache.org/jira/browse/YARN-7892
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>            Priority: Major
>         Attachments: YARN-7892-YARN-3409.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to