[ 
https://issues.apache.org/jira/browse/YARN-7903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356327#comment-16356327
 ] 

Steven Rand commented on YARN-7903:
-----------------------------------

Agreed that it seems weird/wrong to ignore locality when considering which of 
an app's RRs to preempt for. I think it's worth noting though that if we change 
the code to choose the most local request, then we increase the frequency of 
the failure mode described in YARN-6956, where we fail to preempt because 
{{getStarvedResourceRequests}} returns only {{NODE_LOCAL}} RRs, and there 
aren't any preemptable containers on those nodes (even though there are 
preemptable containers on other nodes). I think that we should try to make 
progress on that JIRA as well as this one.

> Method getStarvedResourceRequests() only consider the first encountered 
> resource
> --------------------------------------------------------------------------------
>
>                 Key: YARN-7903
>                 URL: https://issues.apache.org/jira/browse/YARN-7903
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 3.1.0
>            Reporter: Yufei Gu
>            Priority: Major
>
> We need to specify rack and ANY while submitting a node local resource 
> request, as YARN-7561 discussed. For example:
> {code}
>     ResourceRequest nodeRequest =
>             createResourceRequest(GB, node1.getHostName(), 1, 1, false);
>     ResourceRequest rackRequest =
>             createResourceRequest(GB, node1.getRackName(), 1, 1, false);
>     ResourceRequest anyRequest =
>             createResourceRequest(GB, ResourceRequest.ANY, 1, 1, false);
>     List<ResourceRequest> resourceRequests =
>             Arrays.asList(nodeRequest, rackRequest, anyRequest);
> {code}
> However, method getStarvedResourceRequests() only consider the first 
> encountered resource, which most likely is ResourceRequest.ANY. That's a 
> mismatch for locality request.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to