[ https://issues.apache.org/jira/browse/YARN-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753477#comment-13753477 ]
Junping Du commented on YARN-771: --------------------------------- [~bikassaha] b.q. What if we add node to blacklist and them remove that node from blacklist immediately? Wont it end up in both list? Yes. it will appear in both list. However, when going to RM, it will add node first and remove it from blacklist set. So node will not be blacklisting. b.q. Also, should it be an error to specify the same node in both lists in the same method call? In that too, we may end up with the same node in both lists. I may have different idea on this. In general, it is not recommended to put the same node on both lists. However, it may not belonging a wrong behaviour. Let's say in some cases, application want to put nodes that meet requirement A (set A) into blacklist, but don't want to put nodes in requirement B (set B) into list. Application can easily to put set A on additional list and set B on removal list in the same call without taking care the overlap of A and B. Thoughts? b.q. Can we modify TestAMRMClient.testAllocation() to check that on an exception during allocate we continue to preserve the previous blacklist and any new blacklist additions that were made during the allocate call. The test already has support for this. We just need to augment it with blacklist operations. Sure. Thanks for suggestions here and last readable comments. > AMRMClient support for resource blacklisting > --------------------------------------------- > > Key: YARN-771 > URL: https://issues.apache.org/jira/browse/YARN-771 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Bikas Saha > Assignee: Junping Du > Attachments: YARN-771-v1.0.patch, YARN-771-v2.patch, YARN-771-v3.patch > > > After YARN-750 AMRMClient should support blacklisting via the new YARN API's -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira