[ 
https://issues.apache.org/jira/browse/YARN-7919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360830#comment-16360830
 ] 

Haibo Chen commented on YARN-7919:
----------------------------------

Thanks [~rohithsharma] for the quick review!  I believe branch-3.1 was  cut 
right after I uploaded the patch, hence the patch failed to apply. I will 
update the patch to address that.

It is split based on what role of the code is with respect to HBase servers. 
The code that reads/writes to tables is executed in NodeManager as hbase 
clients, TimelineSchemaCreator.java is also executed as hbase clients, so they 
two are grouped together in a module. Then there is FlowRunCoprocessor code 
that runs with Region Servers, so it is separated into a server module. There 
is some code that both the client and server module depend on, that defines 
what the tables are like and what value encoding they have. It is extracted to 
a common module. This is what it looks like with the patch applied.

*hadoop-yarn-server-timelineservice-hbase:*
 * *hadoop-yarn-server-timelineservice-hbase-client*   (code that reads and 
writes to the tables, plus TimelineSchemaCreator.java)
 * *hadoop-yarn-server-timelineservice-hbase-common* (code that defines tables, 
columns, column familys and column prefixes)
 * *hadoop-yarn-server-timelineservice-hbase-server* (FlowRunCoprocessor.java)**

The current Tables, Columns and Column Families contain both the schema 
definition and the code that reads and writes to the tables, so what I did is 
extracting their read/write methods into a ColumnRWHelper class that goes into 
the hbase-client module.

I did not see source files remaining in 
*hadoop-yarn-server-timelineservice-hbase,* not sure if it is caused by the 
error while you were applying the patch.

> Split timelineservice-hbase module to make YARN-7346 easier
> -----------------------------------------------------------
>
>                 Key: YARN-7919
>                 URL: https://issues.apache.org/jira/browse/YARN-7919
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineservice
>    Affects Versions: 3.0.0
>            Reporter: Haibo Chen
>            Assignee: Haibo Chen
>            Priority: Major
>         Attachments: YARN-7919.00.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to