[ 
https://issues.apache.org/jira/browse/YARN-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhenhao Li updated YARN-7926:
-----------------------------
    Description: 
We are a group of researchers from Canada and we are studying refactoring in 
log messages. We found that there are some possible copy and paste errors in 
the log messages, and we think it may cause some confusion when operators are 
reading the log messages.

 

The problem is found in the following two methods:

_org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_createNewApplication()_*
 

and 
 
_org.apache.hadoop.yarn.server.router.clientrm.FederationClientInterceptor._*_getNewApplication()_*

These are two very similar methods (possibly code clones) in different classes.

The log messages in *both methods* are:

_LOG.warn("Unable to_ *_create a new ApplicationId_* _in SubCluster " …);_

_LOG.debug(“_*getNewApplication* try # + … );

Since one method is getting new application and one method is creating new 
application, we believe that the log messages are incorrectly copied and should 
be changed.

Please let us know if there is anything that we can further provide you with 
fixing the problem.

  was:
We are a group of researchers from Canada and we are studying refactoring in 
log messages. We found that there are some possible copy and paste errors in 
the log messages, and we think it may cause some confusion when operators are 
reading the log messages. 

 

The problem is found in the following two methods:

_org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_createNewApplication()_*
 

and 
_org.apache.hadoop.yarn.server.router.clientrm.FederationClientInterceptor._*_getNewApplication()_*

These are two very similar methods (possibly code clones) in different classes. 

The log messages in *both methods* are:
 _LOG.warn("Unable to_ *_create a new ApplicationId_* _in SubCluster " …);__
_ _LOG.debug(“_*getNewApplication* try # + … );

Since one method is getting new application and one method is creating new 
application, we believe that the log messages are incorrectly copied and should 
be changed. 



Please let us know if there is anything that we can further provide you with 
fixing the problem.


> Copy and paste errors in log messages
> -------------------------------------
>
>                 Key: YARN-7926
>                 URL: https://issues.apache.org/jira/browse/YARN-7926
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Zhenhao Li
>            Priority: Minor
>              Labels: easyfix
>
> We are a group of researchers from Canada and we are studying refactoring in 
> log messages. We found that there are some possible copy and paste errors in 
> the log messages, and we think it may cause some confusion when operators are 
> reading the log messages.
>  
> The problem is found in the following two methods:
> _org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_createNewApplication()_*
>  
> and 
>  
> _org.apache.hadoop.yarn.server.router.clientrm.FederationClientInterceptor._*_getNewApplication()_*
> These are two very similar methods (possibly code clones) in different 
> classes.
> The log messages in *both methods* are:
> _LOG.warn("Unable to_ *_create a new ApplicationId_* _in SubCluster " …);_
> _LOG.debug(“_*getNewApplication* try # + … );
> Since one method is getting new application and one method is creating new 
> application, we believe that the log messages are incorrectly copied and 
> should be changed.
> Please let us know if there is anything that we can further provide you with 
> fixing the problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to