[ https://issues.apache.org/jira/browse/YARN-7328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363540#comment-16363540 ]
lovekesh bansal edited comment on YARN-7328 at 2/14/18 6:16 AM: ---------------------------------------------------------------- I have attached the first patch with just disabling memory-mb and vcores. And since we are throwing exception for all mandatory resources, we should addMandatoryResources only after checkMandatoryResources in getNodeResourceInformation. Please let me know your thoughts, accordingly I'll change the test cases. was (Author: lovekesh.bansal): I have attached the first patch with just disabling memory-mb and vcores. And since we are throwing exception for all mandatory resources, we should addMandatoryResources only after checkMandatoryResources in getNodeResourceInformation. > ResourceUtils allows yarn.nodemanager.resource-types.memory-mb and .vcores to > override yarn.nodemanager.resource.memory-mb and .cpu-vcores > ------------------------------------------------------------------------------------------------------------------------------------------ > > Key: YARN-7328 > URL: https://issues.apache.org/jira/browse/YARN-7328 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager > Affects Versions: 3.1.0 > Reporter: Daniel Templeton > Assignee: lovekesh bansal > Priority: Critical > Attachments: YARN-7328_trunk.001.patch > > > We will throw an exception if yarn.nodemanager.resource-types.memory is > configured, but not if .memory-mb or .vcores is configured. We should be > consistent. We should not allow resource types to redefine something for > which we already have a property to set. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org