Konstantinos Karanasos commented on YARN-7920:

Re: configuration, I think it is simpler at the moment to leave it as is (i.e., 
placement-processor/scheduler). I chatted offline with Arun and he is fine with 
is as well.

Re: the .md.vm format, I remember [~cheersyang] used this format for the 
opportunistic containers doc that I had written, so I thought it is preferable. 
Weiwei, any advantages in this format?

Re: the naming, I think all is fine now apart from the NonePlacementProcessor 
that sounds weird. Looking at it better, indeed Default is not okay (initially 
I thought it is a no-op, but in fact it rejects scheduling requests). Any of 
the following is fine with me: DisabledConstraintProcessor, 
UnsupportedConstraintProcessor, RejectConstraintProcessor?

>From a quick look, documentation looks fine. I can make a pass over it before 
>I commit the patch.

> Cleanup configuration of PlacementConstraints
> ---------------------------------------------
>                 Key: YARN-7920
>                 URL: https://issues.apache.org/jira/browse/YARN-7920
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>            Priority: Blocker
>         Attachments: YARN-7920.001.patch, YARN-7920.002.patch, 
> YARN-7920.003.patch, YARN-7920.004.patch
> Currently it is very confusing to have the two configs in two different files 
> (yarn-site.xml and capacity-scheduler.xml). 
> Maybe a better approach is: we can delete the scheduling-request.allowed in 
> CS, and update placement-constraints configs in yarn-site.xml a bit: 
> - Remove placement-constraints.enabled, and add a new 
> placement-constraints.handler, by default is none, and other acceptable 
> values are a. external-processor (since algorithm is too generic to me), b. 
> scheduler. 
> - And add a new PlacementProcessor just to pass SchedulingRequest to 
> scheduler without any modifications.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to