[ 
https://issues.apache.org/jira/browse/YARN-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371129#comment-16371129
 ] 

Rohith Sharma K S commented on YARN-7346:
-----------------------------------------

Spoke to many of our colleagues offline from different upstream Hadoop 
projects. The typical conditional compilation would be  a same as our original 
idea i.e activating respective modules based on profile is set. I think we 
should strict to our original approach and try to solve Jenkins issue where it 
is running for both modules. 

Other way to exploit the Jenkin issue is by providing two different patch in 
different JIRA!
# Provide a patch for hbase-2 module by making HBase-2 module as default 
profile. Do not include hbase-1 src/main java files in module in the patch at 
all. Jenkins runs for HBase-2 module. We can commit it.
# After 1st one is committed, provide a patch for hbase-1 module that includes 
src files and change default profile to HBase-1 as default. This patch 
shouldn't contains hbase-2 module changes so that Jenkins doesn't run for 
hbase-2 modules.
But risk factor in future is any changes made for HBase-2 module end up in 
Jenkins failure. Given, no more changes would come for 
timelineservice-hbase-server module, then we can go ahead with this approach.

IAC, I have dropped a mail to [~aw] and [~ajisakaa] for getting help for this 
from Yetus.



> Fix compilation errors against hbase2 beta release
> --------------------------------------------------
>
>                 Key: YARN-7346
>                 URL: https://issues.apache.org/jira/browse/YARN-7346
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Haibo Chen
>            Priority: Major
>         Attachments: YARN-7346.00.patch, YARN-7346.01.patch, 
> YARN-7346.02.patch, YARN-7346.03-incremental.patch, YARN-7346.03.patch, 
> YARN-7346.04.patch, YARN-7346.prelim1.patch, YARN-7346.prelim2.patch, 
> YARN-7581.prelim.patch
>
>
> When compiling hadoop-yarn-server-timelineservice-hbase against 2.0.0-alpha3, 
> I got the following errors:
> https://pastebin.com/Ms4jYEVB
> This issue is to fix the compilation errors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to