[
https://issues.apache.org/jira/browse/YARN-7856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371814#comment-16371814
]
Sunil G commented on YARN-7856:
-------------------------------
Thanks [~cheersyang]
Few comments.
1. {{equals}} could u pls check a case where one of getAttributePrefix may be
null. (we check both null scenario only now)
2. In {{validateNodeAttributes}} we could add some checks to avoid special
characters etc, correct? like alphanumerical string.
3. May be the number of attributes are smaller, however instead of calling
{{validateNodeAttributes}} with a set of attributes, we could validate each of
these attribute alone.
> Validation node attributes in NM
> --------------------------------
>
> Key: YARN-7856
> URL: https://issues.apache.org/jira/browse/YARN-7856
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, RM
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Priority: Major
> Attachments: YARN-7856-YARN-3409.001.patch
>
>
> NM needs to do proper validation about the attributes before sending them to
> RM, this includes
> # a valid prefix is presented
> # no duplicate entries
> # do not allow two attributes with same prefix/name but different types
> This could be an utility class that can be used on both RM/NM sides.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
